mmurrian

osg cannot be built/linked against within a larger CMake build (e.g., when brought in as add_subdirectory(OpenSceneGraph)) because target_include_directories(osg ...) does not include a build-time path to auto-generated includes; e.g. osg/Config...

osg CMake target does not include auto-generated osg/Config

2

target_include_directories(osg ...) does not include the directory that contains the autogenerated osg/Config. This prevents building and linking against OpenSceneGraph as part of a larger CMake build (e.g., via `add_subdirectory(OpenSceneGraph)`) without...

Was bitwise OR intended here?

7

https://github.com/TheCherno/Hazel/blob/a16f605b3aa82ecf1c47ebd5d505127de81028f2/Hazel/src/Hazel/Events/Event.h#L71 Do you want an already handled event to still be dispatched? If so, no change. If not, this line needs short-circuiting (and a logical OR): `m_Event.Handled = m_Event.Handled ||...

`strstr(line, "\n")` returns NULL if a newline is not found. Dereferencing without a NULL check causes a segmentation fault. https://github.com/vmarkovtsev/DeathHandler/blob/911e4df429a89309b10111d76d232d4a7c2b5485/death_handler.cc#L438 https://github.com/vmarkovtsev/DeathHandler/blob/911e4df429a89309b10111d76d232d4a7c2b5485/death_handler.cc#L440 A bug in addr2line causes it to produce outputs...

static random-number generator 'defeated' by seed in constructor

5

Every construction of an EigenMultivariateNormal instance re-seeds the _static_ random-number generator. This will cause all instances to reset their RNG sequence back to the same output whenever a new EigenMultivariateNormal...