mmsqe

Results 60 comments of mmsqe

transferCoins works but mintWithFaucetService not, seems related to mintAddress change in c5cce923cb3e076341cff5e1ac83069b29628d73, updated in https://github.com/perfectmak/libra-core/pull/40

> Sorry, I don't understand what you mean. Could you please rephrase it for me? 🙏 Thank you! We might just add this [wait](https://github.com/cosmos/iavl/pull/570/files) for the test.

> In the context of ethermint, probabely we need to have a mode that start grpc and json-rpc together, but could leave that to another issue. maybe just query-only flag,...

since `No way to detect data loss` based on current [desgin](https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-075-rpc-subscription.md#issue-2-inconvenient-client-api), not sure if we can deprecate websocket and switch to long poll on events endpoint with after cursor, starting...

> interesting, thanks for the report. We will look into this, this week Thanks, but we might close this issue now, since I see main branch move to context.Context, I...

> if there's a solution in main branch, can we port to 0.47? Since main branch already use [context.Context](https://github.com/cosmos/cosmos-sdk/blob/bafe5040f22c55f5053b34bc0d8095b566022f20/x/upgrade/types/handler.go#L27), I guess we could use [consensusParamsKeeper](https://github.com/evmos/ethermint/pull/1782/commits/b739244dede0652f558339a0608dbe04eebe5377) 1st?

Not sure if there's better way to allow other [modules](https://github.com/mmsqe/cosmos-sdk/blob/ca541702fc13913818241b92f0ec92112b7e3558/types/module/module.go#L559-L564) access updated ctx right after migrate without changing BeginBlock signature

> I guess we should just run migration before everything else, under a minimal context, a special hook just for that, before the BeginBlocker. Do you mean sth like [this](https://github.com/evmos/ethermint/pull/1782/commits/c48f1b65627e3de8c3df9a46c3a96972c2799836),...

> > > I guess we should just run migration before everything else, under a minimal context, a special hook just for that, before the BeginBlocker. > > > >...

I rmb since proto paths need to match folder paths