ethermint icon indicating copy to clipboard operation
ethermint copied to clipboard

Add query-only mode flag

Open mmsqe opened this issue 2 years ago • 3 comments

Closes: #1359

Description


For contributor use:

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

  • [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • [ ] Reviewers assigned
  • [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

mmsqe avatar Sep 28 '22 07:09 mmsqe

In the context of ethermint, probabely we need to have a mode that start grpc and json-rpc together, but could leave that to another issue.

yihuang avatar Sep 28 '22 07:09 yihuang

In the context of ethermint, probabely we need to have a mode that start grpc and json-rpc together, but could leave that to another issue.

maybe just query-only flag, we can pass like grpc|jsonrpc|grpc,jsonrpc

mmsqe avatar Sep 29 '22 01:09 mmsqe

In the context of ethermint, probabely we need to have a mode that start grpc and json-rpc together, but could leave that to another issue.

maybe just query-only flag, we can pass like grpc|jsonrpc|grpc,jsonrpc

or --json-rpc-only which implies all the dependency services.

yihuang avatar Sep 29 '22 07:09 yihuang