Matt Pharr

Results 117 comments of Matt Pharr

Slightly confusingly, this is actually bump mapping, not displacement mapping. (Which is currently only supported for `plymesh` shapes--this should be fixed...) I am almost certain that the issue is due...

If this comes up again, I'm curious if expanding out the `EnableIfConvertibleFrom` at line 353 using its definition at line 326 would work around this--i.e. is the templating getting that...

Interesting; that code is correct in the pbrt-v3 source code but seems to be incorrect in the online text. I will look into what happened there. https://github.com/mmp/pbrt-v3/blob/aaa552a4b9cbf9dccb71450f47b268e0ed6370e2/src/core/medium.cpp#L194. Sorry for any...

Hi, Brad-- I'm glad the book has been useful to you, and nice debugging there digging into this! I think what is going on is related to pbrt's handling of...

The issue seems to be in the third-party OpenEXR library. You might try updating it to a more recent release (the version used in pbrt-v3 dates to 2018, so I...

It is a typo, thanks for reporting! I'll push an update to the online errata and the book website in a little while. @steimich96 let me know how you want...

That would be nice--PRs welcome!

Fun to see those pictures! @knightcrawler25 thanks for letting me know about that. I'll send the publisher a note and see if there is anything to be done. It looks...

Very strange; it's not immediately obvious why normals would have a problem. (As far as I know, they don't go through any dodgy pointer casts like vertex positions used to...)

It would be good to update pbrt to use a modern version of ptex, but unfortunately it's not straightforward. I've pushed a branch, `update-ptex`, that updates Ptex to v2.4.2 but...