Matt Mitchell
Matt Mitchell
@jaredpar For docs on the TargetRid.
Yeah this looks good to me. @jaredpar I'll tag you on the p3 update PR
It was not on my radar to implement, but I can if need be.
> Is it normal to keep service connection PATs in this vault? This won't actually cause the service connection to update, right? Correct. You still need to update the service...
> The problem that this would bring is that secret-manager will cycle this PAT automatically. Its value will never be available to be seen by a human, so by the...
Okay, these guardrails do not need to be 'new'. They existed: https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs#L331-L341
https://github.com/dotnet/arcade/blob/main/eng/publishing/v3/publish.yml#L166 This is set incorrectly.
And the safety check is never executed.
I don't know the reason. I think it has always been like this, actually. At least since the move to Helix. The original commit of the UnitTests.proj is from early...
Yeah, mainly for tracking. I was going to look into it if I found time but I didn't want it to get lost.