Matt Mitchell
Matt Mitchell
Yes, there would be no step 3 with these improvements.
@cdmihai I think this will happen if you archive even on failure.
This is the initial workspace cleanup, which means that a previous run still has processes running. AFAIK, this shouldn't happen because the previous run's processes should be killed by this...
@omajid I think we want the following state: - When building from a git clone of the VMR, the sha of the VMR is used for all of the repo...
> No worries! I don't want to step on any toes here. And you're definitely not stepping on toes. Any help is appreciated.
> This set of changes work for me: [omajid/dotnet-dotnet@1fe5b89](https://github.com/omajid/dotnet-dotnet/commit/1fe5b89c36d029c23c49f1365c64e182f695f3ce). I can build a git-archive from the VMR with these changes. > > @mmitche is this along the lines of what...
> I found something that I can't figure out. > > The file `./artifacts/obj/installer/artifacts-layout/.version` is supposed to contain the commit sha too. It is generated by https://github.com/dotnet/dotnet/blob/a6e7f40ccdcea190d96ba5915bff6269ff569500/repo-projects/installer.proj#L119-L126 > > However,...
Don't think so.
My change should have resolved the issue immediately (since it affected sdk's official builds immediately). If you see this again, let us know
Looking closer, the main build is broken, this change https://github.com/dotnet/installer/pull/19641 will end up being the resolution.