mmarton

Results 20 comments of mmarton
trafficstars

Okay, i can accept that argument, but still weird that some operators count and some doesn't. Anyway, since you changed the calculation making it harder to stay inside the recommendations,...

And another theoretical question: Shouldn't optional chaining counted too? `return $object->getX()?->getY()` is technically `return $object->getX() !== null ? $object->getX()->getY() : null`

brake and continue in a loop are (almost) always inside of an if statement, so that would be double counting imo

Yes, and I can use goto and eval() too :) But I don't think there is an common part of the ones who are doing that and who are caring...

> @MarkBaker The thresholds can be customized per project via the project custom ruleset: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#genericmetricscyclomaticcomplexity yes, I can, and I'm doing it right now in my projects. But the question...

Hi @gmponos Did you find a solution for this? I would like to catch any forgotten dump() statement before our code hits production.

Not that different. dump() was just an example that recently happened to us. What I would like to catch in general is any call to a dev dependency (composer require-dev...

I see your points. It's just having warnings as the expected behavior is just makes an unprofessional impression. Not something I would expect from an official symfony tool. But I...

One of my the oldest issue finally solved by release v4 :D

Nope, it's still not clear how to do it in the right way :/