Matthew Biscocho
Matthew Biscocho
Moving this out of draft for review
> > There are enough additional dependencies that I feel strongly this should be another module. > > WDYT? Sorry, I somehow completely missed this comment. When you say be...
> ``` > io.prometheus:prometheus-metrics-config:1.1.0 (1 constraints: 3e164ed8) > io.prometheus:prometheus-metrics-exposition-formats:1.1.0 (1 constraints: 0405f335) > io.prometheus:prometheus-metrics-model:1.1.0 (2 constraints: 411b133b) > io.prometheus:prometheus-metrics-shaded-protobuf:1.1.0 (1 constraints: > ``` > > No, there are 4 dependencies....
@dsmiley or anyone else interested in reviewing. Was curious for more feedback on approach. Is this going in the correct direction or do some disagree if this is correct implementation...
> Much better. I know I've been a bit picky/detailed but I'm trying to achieve a level of clarity & conciseness here that will end up being repeated for the...
> What's here looks good to me. Just need to add more; lots more metrics. Maybe it'll evolve a little once you add another category. My interest on this at-work...
> It doesn't feel right to merge this PR right now. Needs docs. Also the choice of what metrics are done so far is inverted from the value that would...
Added ref-guide documentation on Prometheus endpoint
> I'd like to suggest an integration test showing all the output (say to a file) stripped of numbers (to remove brittle/changing stuff) to show that we export what we...
> I tried this PR locally using the "techproducts" example. I thing I noticed is that the metrics filtering appears to not work, which is a big problem. A test...