Matthew Biscocho
Matthew Biscocho
> Oops; maybe I was hurried. I'm glad the category works at least! The other filtering options could be deferred to a future JIRA by matching the prometheus name. It's...
> This is super close now. Can you propose a brief CHANGES.txt under 9.7 "New Features" (I think it's closer to this than an improvement). Added entry into CHANGES.txt
Hey @gerlowskija, should be the last API for SOLR-16470 whenever you get time to review. Thanks!
Hey @gerlowskija made the changes but ended up kind of inflating this PR to support the OpenAPI code generation and moving files. Lmk if this went the right direction
> Alright, merged in the latest 'main' and synced it with the changes here. The only real change of note is that the interface file is now named 'ReplicationApis.java' (I...
Added in some documentation to the ref-guide for the filecontent api and it's parameters. Also made a small change to fix precommit. Went back through the merge and rebase and...
> The introduction of use of OTEL's "scope" will be very interesting & foundational to Solr's adoption of OTEL metrics. I think that's the next step after this PR. This...
Actually the more I work on this, I think I am going to go with the path of renaming `SolrMetricsContext` to `SolrMetricsScope`. This is outside the scope of this PR,...
> I think scope is intended to basically refer to all of Solr (e.g. be something like "org.apache.solr"), possibly with module consideration added (e.g. add ".llm"). Actually this makes sense....
So I didn't move attributes into SolrMetricsContext. Ended up being a bigger refactor because currently keeping Dropwizard in parallel temporarily to incrementally migrate. Maybe will do it closer to the...