Matthias Kurz

Results 1121 comments of Matthias Kurz

https://travis-ci.org/github/lightbend/config/jobs/719261828#L282-L285

``` [error] /home/travis/build/lightbend/config/config/src/main/java/com/typesafe/config/impl/SerializedConfigValue.java:327:1: cannot find symbol [error] symbol: variable MAX_BYTES_LENGTH [error] location: class com.typesafe.config.impl.SerializedConfigValue [error] if (strVal.getBytes().length >= MAX_BYTES_LENGTH) { ```

Ping @havocp, would be nice if you could have another look.

@havocp I think this pull request can be reviewed again :wink:

What about upgrading scala-xml only if using Scala 3? We did that in play-ws and twirl: * https://github.com/playframework/play-ws/blob/6f975d1fe66f50f8a3799f51ec4a424f3fcc1c62/project/Dependencies.scala#L39-L44 * https://github.com/playframework/twirl/blob/e307b6d051fd667adae96ee66abba1e57a4dfcd7/build.sbt#L87-L92 ```sbt libraryDependencies += "org.scala-lang.modules" %%% "scala-xml" % { CrossVersion.partialVersion(scalaVersion.value) match...

No issues with that. It would be nice to have at least milestone releases with Scala 3 asap, so we can use them in Play. Thanks!

Hi! Will this Scala 3 support make it into akka-http 10.2.x? Or will there be a new major version 10.3.x when akka 2.7.x will be released?

One more thing: Because in https://github.com/playframework/playframework/pull/9488 we have lots of `args: (Symbol,Any)*` _only_ changes, it's a good idea to pass `(implicit d: DummyImplicit)` to the "new" generated `apply` and `render`...

More notes: When using `@deprecatedParams` without `@templateFunctionName` we can then just automatically add `(implicit d: DummyImplicit)` to the new `f` method (meaning we just have to look if there are...