config
config copied to clipboard
Fix https://github.com/lightbend/config/issues/627
I fix https://github.com/lightbend/config/issues/627 by referring to https://github.com/geotools/geotools/pull/2265/commits/7b52e15943846f72f0d85cc9121d330daf8c6c6e#
Hi @JenniferJohnson89,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
https://travis-ci.org/github/lightbend/config/jobs/719261828#L282-L285
[error] /home/travis/build/lightbend/config/config/src/main/java/com/typesafe/config/impl/SerializedConfigValue.java:327:1: cannot find symbol
[error] symbol: variable MAX_BYTES_LENGTH
[error] location: class com.typesafe.config.impl.SerializedConfigValue
[error] if (strVal.getBytes().length >= MAX_BYTES_LENGTH) {
@mkurz Could you please check this? Thanks!
@havocp @mkurz Will this be ok to merge? Please let me know if you have any questions or suggestions. I will try my best to make the commits satisfactory. Thanks!
@mkurz @havocp Would you mind checking if this new solution is acceptable? Thanks!
@mkurz @havocp Please feel free to let me know if you have any concerns or questions. Thanks.
@havocp Will this be ok to merge? Please let me know if I can help. Best wishes.
Ping @havocp, would be nice if you could have another look.
@havocp I think this pull request can be reviewed again :wink:
Ping @havocp
We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by
We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by
But here is not a feature, just a bug.