config icon indicating copy to clipboard operation
config copied to clipboard

Fix https://github.com/lightbend/config/issues/627

Open JenniferJohnson89 opened this issue 5 years ago • 11 comments

I fix https://github.com/lightbend/config/issues/627 by referring to https://github.com/geotools/geotools/pull/2265/commits/7b52e15943846f72f0d85cc9121d330daf8c6c6e#

JenniferJohnson89 avatar Aug 19 '20 12:08 JenniferJohnson89

Hi @JenniferJohnson89,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Aug 19 '20 12:08 lightbend-cla-validator

https://travis-ci.org/github/lightbend/config/jobs/719261828#L282-L285

mkurz avatar Aug 19 '20 12:08 mkurz

[error] /home/travis/build/lightbend/config/config/src/main/java/com/typesafe/config/impl/SerializedConfigValue.java:327:1: cannot find symbol
[error]   symbol:   variable MAX_BYTES_LENGTH
[error]   location: class com.typesafe.config.impl.SerializedConfigValue
[error]             if (strVal.getBytes().length >= MAX_BYTES_LENGTH) {

mkurz avatar Aug 19 '20 12:08 mkurz

@mkurz Could you please check this? Thanks!

JenniferJohnson89 avatar Aug 20 '20 05:08 JenniferJohnson89

@havocp @mkurz Will this be ok to merge? Please let me know if you have any questions or suggestions. I will try my best to make the commits satisfactory. Thanks!

JenniferJohnson89 avatar Aug 25 '20 09:08 JenniferJohnson89

@mkurz @havocp Would you mind checking if this new solution is acceptable? Thanks!

JenniferJohnson89 avatar Aug 28 '20 15:08 JenniferJohnson89

@mkurz @havocp Please feel free to let me know if you have any concerns or questions. Thanks.

JenniferJohnson89 avatar Sep 07 '20 11:09 JenniferJohnson89

@havocp Will this be ok to merge? Please let me know if I can help. Best wishes.

JenniferJohnson89 avatar Sep 28 '20 12:09 JenniferJohnson89

Ping @havocp, would be nice if you could have another look.

mkurz avatar Nov 06 '20 18:11 mkurz

@havocp I think this pull request can be reviewed again :wink:

mkurz avatar Dec 16 '20 15:12 mkurz

Ping @havocp

mkurz avatar Apr 09 '21 16:04 mkurz

We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by

ennru avatar Jul 06 '23 08:07 ennru

We do not intend to extend the functionality of "Typesafe Config" further. See https://github.com/lightbend/config#maintained-by

But here is not a feature, just a bug.

joe-mojo avatar Jul 06 '23 11:07 joe-mojo