Matthias Kurz

Results 1121 comments of Matthias Kurz

> Let me try and get a prototype PR out during the upcoming holidays. @TheAntimist Sure :wink: I am happy to review.

@TheAntimist Will you work on this?

@TheAntimist Oh, I am sorry, hope you get better soon! I didn't want to push you, just asking if there is still interest. Take your time.

> `master` is the upcoming 2.9, so that would just mean 'not backporting to 2.8.x', right? Exactly.

> Nonetheless there's something to be said for holding back bigger changes to master to reduce conflicts while backporting important smaller changes - WDYT? I have a feeling that we...

akka-http 10.2.3 contains a fix [for an issue](https://github.com/akka/akka-http/issues/1240) that Play worked around in #7515: - https://github.com/akka/akka-http/pull/3705 When upgrading akka-http in Play maybe wen can remove that fix in Play now?...

One more: When tackling the akka-http 10.2.x upgrade maybe we can also finally fix #8239, which should be doable now that https://github.com/akka/akka-http/pull/2005 was merged (long time ago already)

One more thing: When upgrading to akka-http 10.2.x we should then also use the latest snapshot version in cron jobs: https://github.com/playframework/playframework/blob/71707c5861431aed58c02e9f5ed3b9312926c2ed/project/Dependencies.scala#L10-L11 via `sys.props.getOrElse("akka.http.version", "10.2.") `

Also don't forget to upgrade akka-http in the `grep` regex here: https://github.com/playframework/playframework/blob/619b3190e9235fba10aba43a08b55a2ab373a347/scripts/scriptLib#L29 Also check scala-steward conf. Also see * https://doc.akka.io/docs/akka-http/current/release-notes/10.2.x.html * https://github.com/akka/alpakka/pull/2650

Note: In #11081 I already upgraded the akka-http 10.2.x by just bumping the version, however this isn't perfect yet. I had to disable tests to make that pr finally pass,...