Michael Kelley

Results 51 comments of Michael Kelley

Regarding offline testing, there are some notes at: https://astroquery.readthedocs.io/en/latest/testing.html Another benefit to offline tests is that the output from the "server" is always the same (i.e., the ephemeris never changes)....

Regarding the output, I think three return variables is fine, and leaving `systemtable` as a dictionary is also OK. As for `Table` vs. `QTable`, yeah, try out `QTable` first.

Hi @emolter , Were you able to fix the mock tests? The tests seem to be passing now.

Also, the file coverage.xml seems to have been added by mistake. Please remove it.

The "codecov/patch` details list all the lines that were not tested, e.g., astroquery/solarsystem/pds/core.py#L50 states that line 50 of that file was not covered by the tests. I verified this locally...

Perhaps you can annotate the table with a loop, adding the units to the `Column.unit` properties? ```python >>> from astropy.table import Table, QTable >>> tab = Table(rows=[{'a': 1}]) >>> tab...

How about parsing the string? `Time.now().utc.iso[:16]`

@bsipocz is correct. The current functionality is mapped to the MPC Ephemeris Service https://minorplanetcenter.net/iau/MPEph/MPEph.html A new NEOCP/PCCP addition would be great.

Ah, I see, the MPC's ephemeris service fails for '2008 JG' but does work for 613986, despite these being the same object. You can test out various objects using their...

For the MPC observation database, when I search for 2008 JG via https://minorplanetcenter.net/db_search , the returned URL is https://minorplanetcenter.net/db_search/show_object?object_id=613986 , i.e., they are resolving 2008 JG to the permanent designation...