mjog

Even better, just treat albums with an empty/blank Album Artist the same as if it was "Various Artists". None of my compilations are tagged as "Various Artists", hence none of...

Example logs from CI test failure are here: https://gitlab.gnome.org/GNOME/geary/-/jobs/697329 The failing test is loading TNEF data from this file: https://gitlab.gnome.org/GNOME/geary/-/blob/mainline/test/data/basic-multipart-tnef.eml

The Flatpak CI build pulls ytnef git master and builds that, the other CI pipelines use whatever Ubuntu and Fedora have packaged - currently the latest release. It's only the...

Looks like even with the TNEFInitialize call in place it's still a problem: https://gitlab.gnome.org/ogtifs/geary/-/jobs/698358 The default attachments size is probably fine given contemporary RAM configs and email attachment size limits...

Hmm, so what's the semantics of `TNEFParseMemory` (and hence `TNEFParse`) wrt the TNEF param? It's a caller-initialised, pass-by reference (as in pass-by-pointer) value, right? Those functions expect it to be...

One other question, it looks like we should be freeing `TNEFStruct` with a call to `TNEFFree`, I assume that's mandatory?

Yup, so we can make sure TNEFInitialize is always called by adding a constructor for the struct in the VAPI that is bound to it, and then ensure we actually...

@ohwgiles NB, my bad on the TNEFFree thing, missed that in the VAPI. Lets take this conversation over to the Geary MR though - I no longer think there's anything...

I could look at fleshing out the example admin a bit, but would you be interested in merging a more elaborate fix for this? I see three possible approaches: 1....

FWIW, GNOME Software is now showing them in the right order.