Matt Jankowski

Results 523 comments of Matt Jankowski

Closing due to merge conflicts and lack of activity -- that said, this seems like a reasonable change to consider, so if you want to push forward can you rebase...

Closing due to merge conflicts and lack of consensus on initial feature idea -- if you feel strongly this should be considered again, can you rebase the branch and reopen...

Closing due to merge conflicts and no updates in ~1 year ... but I think this is potentially useful ... if you'd like, can you rebase and reopen? (we can...

@ykzts do you want to rebase and keep pushing this (or similar) forward?

It looks like that kt-paperclip change was merged and released in v7.2.0, which we are upgraded past now. If this is still relevant, can you rebase? If not, close.

Rebased after https://github.com/mastodon/mastodon/pull/28864 added the coverage for missing classes. This one is now basically two things: moving the error handling to concern, adding i18n strings. If we only want one...

Rebased this after errors concern merged, so is this now just a) the i18n stuff, b) helper methods for that, c) spec improvement to check response body in addition to...

Sounds good. Let's do nothing with this for now - I'll leave the PR open and wait on all new mailers to be done. If at that point there's still...

With the welcome email merged, I reviewed this again -- that email does NOT have the same shared markup, so this is not as straightforward. We could go a custom...