Matt Jankowski

Results 523 comments of Matt Jankowski

This is rebased/updated, but blocked on both a) the chewy version 8 support/PR; b) the chewy 7 relaxed ES version support PR. Chewy appears to be only sort of maintained...

Rebased after https://github.com/mastodon/mastodon/pull/30157 merged. This is still pointing to the WIP PR branch for chewy 8. I'll keep monitoring that and update if/when that releases. Fortunately, we got the faraday...

Closing due to ~1yr of no activity, and no response to last comment (re: moving file instead of adding). If you want to pursue that approach, can you rebase/reopen with...

I think this could be rebased and merged (removing gem), given negligible perf benefits in all supported rubies which are not EOL'd now.

Closing due to no activity in ~1 year and merge conflicts -- if this is still relevant, can you fix the lint errors, rebase, and comment/reopen?

> @ClearlyClaire I layered this with the other PR, should have not done that? As it looks like 4 files now, but two of them are already covered by the...

Since this issue, we have: - Upgraded to Rails 7.1 - Upgraded Ruby to 3.2 - Replaced sprockets with propshaft - Done a bunch of misc deprecation cleanup, embrace of...

Can you rebase this, and maybe add a fuller RTLO scenario to the spec to show what's happening?

Closing since similar change added as side effect of https://github.com/mastodon/mastodon/pull/29388

Could you rebase this (subsequent changes may have addressed some of these things), and maybe also split this up into narrower one-off PRs with each change (and an explanation) ......