Matt Jankowski
Matt Jankowski
Relevant to https://github.com/mastodon/mastodon/issues/21386 - after this change to better isolate the metrics, we could do something similar to the domains cli task and allow a `--format` option to get json...
Closing in favor of linked PR.
Much of the base class extraction here accomplishes some of what the 3 other recent api/pagination-related PRs do. Will rebase this after those are in and see what's left.
Closing this in favor of the few remaining api pagination PRs that are open (which do almost all of this themselves).
I suppose it would ... there are all validations there but I guess data could pre-date the validations or have slipped in via some path that does not validate. Maybe...
Updated each migration to include a de-duplication query as part of the `up` direction. Assuming that duplicate data is rare, the time added by that query should be negligible.
Updated to order the columns in a way where existing indexes might be replaced in two of the cases.
> I pushed the two commits back on your branch Ah, thanks -- I rebased to fix conflicts and then force pushed back up, which probably dropped those commits.
Rebased this, preserved the added data tests, but in style of https://github.com/mastodon/mastodon/pull/28886
Is this one waiting on anything from me, or just more reviewer time?