Ryohsuke Mitsudome
Ryohsuke Mitsudome
Thanks for the PR. The content looks okay, but you have to sign-off your commits to pass the DCO check CI. https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/commit-guidelines/#commit-rules
Regarding ITRI's comment: https://github.com/autowarefoundation/autoware.universe/issues/551#issuecomment-1211529554 GNSS-INS driver is ready for testing, but the code is private now. They need internal review to find if they can share the code.
From yesterday's ASWG, we reviewed the scope of this issue. I have confirmed with LeoDrive that their current demand is to detect localization failure as quick as possible. We can...
@cyn-liu Are you still investigating this issue?
Relevant issue: https://github.com/autowarefoundation/autoware.universe/issues/2044
@ktro2828 Are you done with the review of the PR? If so, I would like you to give approval so that we can merge.
@djargot Are there any other remaining issues? If not, I would like to close this issue. (and close https://github.com/autowarefoundation/autoware.universe/pull/1866 if it is not needed anymore)
@djargot friendly ping
@alanmengg friendly ping.
@miursh is off for a week and won't be able to work on this until next week.