autoware.universe icon indicating copy to clipboard operation
autoware.universe copied to clipboard

Implement sensor drivers for ROS 2

Open BonoloAWF opened this issue 2 years ago • 21 comments

Checklist

  • [X] I've read the contribution guidelines.
  • [X] I've searched other issues and no duplicate issues were found.
  • [X] I've agreed with the maintainers that I can plan this task.

Description

Implement sensor drivers for ROS 2

Purpose

The Bus ODD is being developed in ROS 2 which requires porting sensor drivers where required

Possible approaches

Find open source sensor drivers or implement the required drivers

Definition of done

  • [ ] List of sensors on the bus
  • [ ] List of missing ROS 2 drivers
  • [ ] Development of missing drivers

BonoloAWF avatar Mar 21 '22 15:03 BonoloAWF

Yang shared https://github.com/Kitware/LidarView, which might help us design a unified sensor driver for different LiDARs. We should go through different LiDAR implementation (ros-driver, autoware.auto, Nagoya University implementation) to have the best design for Autoware.

mitsudome-r avatar Mar 23 '22 14:03 mitsudome-r

@BonoloAWF Could you remove my name from assignees? I'm not concerned with this issue.

TakumiKozaka-T4 pushed a commit to TakumiKozaka-T4/autoware.universe that referenced this issue 22 hours ago

I didn't push anything. I only updated my forked repository.

TakumiKozaka-T4 avatar Mar 24 '22 00:03 TakumiKozaka-T4

Sensor Type Sensor Model Sensor Driver
Radar Delphi ESR Missing
Lidar Ouster OS1-64 OS1-64 ROS2 Driver
GNSS-INS Trimble BX992-INS Missing
Camera Onsemi AC-AR0231 Missing

senagolcuk avatar Apr 04 '22 15:04 senagolcuk

@mitsudome-r will check with ITRI about ROS2 drivers for their platform

mitsudome-r avatar May 10 '22 08:05 mitsudome-r

@hueirutseng what is the status update regarding upgrading ROS 2 drivers for the Bus ODD ITRI platform? Are there any missing drivers?

BonoloAWF avatar May 23 '22 07:05 BonoloAWF

@BonoloAWF The driver of camera AR0231 tested OK for ROS2.

jason914 avatar May 24 '22 01:05 jason914

@jason914 Could you provide a similar table that @senagolcuk provided in his comment? ( including the link to the code of each driver)

mitsudome-r avatar May 24 '22 08:05 mitsudome-r

Sensor Type Sensor Model Sensor driver Status
Radar Delphi ESR Missing Work in progress
Lidar Ouster OS1-64 OS1-64-ROS2 driver Tested OK
GNSS-INS Trimble BX992-INS Missing Work in progess
Camera Onsemi AC-AR0231 Private code(Please contact Neousys for source code) Tested OK

jason914 avatar May 25 '22 08:05 jason914

@jason914 Thanks for posting the table. Do you have any updates + estimated timeline on Radar and GNSS-INS sensor driver?

mitsudome-r avatar Jun 07 '22 08:06 mitsudome-r

Sensor Type Sensor Model Sensor driver
Radar Delphi ESR WIP, Estimated test date is the end of Oct.
Lidar Ouster OS1-64 ros2-ouster-driver
GNSS-INS Trimble BX992-INS Ready, Waiting for official upload space.
Camera Onsemi AC-AR0231 Private code, Camera manufacturer does not provide code.

mikechan0731 avatar Jun 08 '22 02:06 mikechan0731

Expected message for GNSS is explained here: https://github.com/autowarefoundation/autoware_msgs/pull/24

mitsudome-r avatar Jun 21 '22 08:06 mitsudome-r

Once we have all drivers available, we can merge the information with the list created in the hardware WG and post it in autoware website.

mitsudome-r avatar Jul 05 '22 08:07 mitsudome-r

@senagolcuk could you update here with the sensor drivers used in the ISUZU bus project?

@meliketanrikulu can you share the estimated timeline for the open sourcing of the applanix driver?

xmfcx avatar Jul 19 '22 08:07 xmfcx

Sensor Type Sensor Model Sensor Driver Status
Lidar Velodyne Puck Lidar Velodyne Driver
Lidar Velodyne Ultra Puck Lidar Velodyne Driver
GNSS-INS Applanix POS LVX Applanix Driver
Camera LucidVisionLabs Triton 5.4 MP LucidVisionLabs Triton Driver

senagolcuk avatar Jul 20 '22 13:07 senagolcuk

Applanix POS LVX GNSS-INS driver will be published here: https://github.com/autowarefoundation/applanix

xmfcx avatar Jul 26 '22 16:07 xmfcx

@senagolcuk Could you tell me why your sensor driver status for lidar is "Work in progress"? If you have the link to the driver that you are using, could you share it as well?

mitsudome-r avatar Jul 26 '22 16:07 mitsudome-r

@mitsudome-r

I'm updating now.

senagolcuk avatar Jul 27 '22 09:07 senagolcuk

Applanix POS LVX GNSS-INS driver will be published here: https://github.com/autowarefoundation/applanix

Added applanix POS LVX GNSS-INS driver.

meliketanrikulu avatar Aug 01 '22 22:08 meliketanrikulu

I have a question. Is it planned that OS1-64-ROS2 driver will be included in the Autoware.Universe like Velodyne drivers are? I see OS1-64 in the comment above, but cannot find a PR regarding that.

sglee-morai avatar Aug 02 '22 08:08 sglee-morai

@mikechan0731 Could you update this comment to add the link to the drivers that you are using?

mitsudome-r avatar Aug 02 '22 08:08 mitsudome-r

@meliketanrikulu thanks for Applanix Driver. I'm updating the table for the new driver.

senagolcuk avatar Aug 02 '22 11:08 senagolcuk

Sensor Type Sensor Model Sensor Driver Status
Radar Delphi ESR WIP, Estimated completion date is the end of August
Lidar Ouster OS1-64 ros2-ouster-driver
GNSS-INS Trimble BX992-INS Private code, GNSS-INS manufacturer does not provide code.
Camera Onsemi AC-AR0231 Private code, Camera manufacturer does not provide code.

jason914 avatar Aug 11 '22 04:08 jason914

@senagolcuk could you update the list with the https://github.com/autowarefoundation/lucid_vision_driver driver?

xmfcx avatar Aug 16 '22 07:08 xmfcx

@xmfcx I updated it.

senagolcuk avatar Aug 16 '22 13:08 senagolcuk

Regarding ITRI's comment: https://github.com/autowarefoundation/autoware.universe/issues/551#issuecomment-1211529554 GNSS-INS driver is ready for testing, but the code is private now. They need internal review to find if they can share the code.

mitsudome-r avatar Aug 30 '22 07:08 mitsudome-r

Since we've gathered possible sensor drivers, we can close this issue.

xmfcx avatar Sep 06 '22 16:09 xmfcx

https://github.com/autowarefoundation/autoware-projects/wiki/Bus-ODD-Project related.

xmfcx avatar Sep 06 '22 16:09 xmfcx