Tiago Costa comments

Results 61 comments of


                                            Tiago Costa

DeprecationWarning: The Buffer() and new Buffer() constructors are not recommended

@jahewson with the new node versions the deprecation logs are a constant. Can you take care of this?

chore(NA): remove src folder requirement from packages (part 2)

@elastic/shared-ux @elastic/security-solution-platform @elastic/kibana-docs @elastic/kibana-performance-testing @elastic/ml-ui @elastic/kibana-presentation @elastic/apm-ui @vigneshshanmugam can I have your review here please?

chore(NA): remove src folder requirement from packages (part 2)

@elasticmachine merge upstream

chore(NA): remove src folder requirement from packages (part 2)

This PR is only touching the packages layout around the src folder. I'm going ahead and merge this one, just let me know if you have further feedback.

yarn kbn bootstrap fails to run without network

Could you please try to setup the following environment variable before running bootstrap `BUILD_TS_REFS_DISABLE=true` ? After this please try to run `yarn kbn bootstrap --offline`

Using relative paths - sources still contains absolute paths

@jsonUK could please verify if the absolute paths you have are coming from source-maps? Maybe we can just disable and delete the cache to understand if the new generated cache...

Should source maps be cached?

@stevenvachon could your issue be related to https://github.com/webpack-contrib/cache-loader/issues/70 ?

Update README.md

Also please sign the contributor agreement @akhilbhardwaj23

Update example, tests and dependecies for react 16 support

@petrbrzek @dimapaloskin can we move this forward in order to officially support react 16?

The inferred type of "X" cannot be named without a reference to "Y". This is likely not portable. A type annotation is necessary.

@weswigham Thanks for looking into the issue. What you wrote makes sense in my head as an explanation about why it is this bug happening. Let me know if I...