kibana
kibana copied to clipboard
chore(NA): remove src folder requirement from packages (part 2)
Continuation of https://github.com/elastic/kibana/pull/138038
Pinging @elastic/kibana-operations (Team:Operations)
Note: https://github.com/elastic/kibana/pull/137448 adds new packages which will likely need to be adapted too
@elastic/shared-ux @elastic/security-solution-platform @elastic/kibana-docs @elastic/kibana-performance-testing @elastic/ml-ui @elastic/kibana-presentation @elastic/apm-ui @vigneshshanmugam can I have your review here please?
@elasticmachine merge upstream
:green_heart: Build Succeeded
- Buildkite Build
- Commit: e3be45b63ed9b8204345ea798d93f837e6b2f80f
- Storybooks Preview
Metrics [docs]
Public APIs missing comments
Total count of every public API that lacks a comment. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats comments
for more detailed information.
id | before | after | diff |
---|---|---|---|
@kbn/analytics |
69 | 73 | +4 |
@kbn/core-saved-objects-migration-server-internal |
19 | 74 | +55 |
@kbn/core-saved-objects-server-internal |
9 | 66 | +57 |
total | +116 |
Public APIs missing exports
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0.
Run node scripts/build_api_docs --plugin [yourplugin] --stats exports
for more detailed information.
id | before | after | diff |
---|---|---|---|
@kbn/core-saved-objects-migration-server-internal |
0 | 43 | +43 |
@kbn/core-saved-objects-server-internal |
3 | 4 | +1 |
total | +44 |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
kbnUiSharedDeps-srcJs |
3.8MB | 3.8MB | -2.1KB |
Unknown metric groups
API count
id | before | after | diff |
---|---|---|---|
@kbn/analytics |
69 | 73 | +4 |
@kbn/core-saved-objects-migration-server-internal |
24 | 100 | +76 |
@kbn/core-saved-objects-server-internal |
9 | 66 | +57 |
@kbn/shared-ux-storybook-config |
0 | 2 | +2 |
total | +139 |
History
- :green_heart: Build #67981 succeeded 432034361a258689744ac192a994ed34b502789a
- :green_heart: Build #67717 succeeded 1e8cacc749e8d54a6200c192ffaccd59cc60338f
- :green_heart: Build #67505 succeeded e3a7ba3c065cf4a3a1af0e28dc6406069170179b
- :green_heart: Build #67186 succeeded 41ed0435be6b9edb054587563f7431b7a0eebea1
- :broken_heart: Build #67155 failed ddf93d620f55139156770275e06ff129f782d3d9
- :green_heart: Build #66613 succeeded 7f7ef08760063210527a4e43f8262a4ba065713a
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
This PR is only touching the packages layout around the src folder. I'm going ahead and merge this one, just let me know if you have further feedback.