Niklas Mischkulnig

Results 572 comments of Niklas Mischkulnig

* **#86737** * **#86865** 👈 (View in Graphite) * **#86875** * `canary` This stack of pull requests is managed by Graphite. Learn more about stacking.

Tested manually on an app, fails with this at runtime (500!): ``` ⨯ TypeError: Cannot assign to read only property 'deploymentId' of object '#' at async Module.b (.next/server/chunks/[root-of-the-server]__4c694765._.js:3:5532) { ```...

Now actually containing tests and verified working on an actual app 😬

I'm afraid that adding `pino` to `serverExternalPackages` is the only solution here. Pino is way too dynamic for Turbopack to be able to figure out all required files automatically: https://github.com/pinojs/pino/blob/7dd79a3370f34e0c092dcbc2c6fb1748afcc1cdd/lib/transport.js#L94...

> Finally, i do wonder if we should be preferring .ts over .js in this case. I understand why that is the typescript semantics (they need types), but we don't,...

(I guess https://github.com/vercel/next.js/pull/86630 and https://github.com/vercel/next.js/pull/86769 are related to this)

Strange, https://github.com/vercel/next.js/pull/86697 should have fixed that. Could you verify if running it with Node instead of Bun works fine? Then it seems like a bug in bun

I recommend that you report this to bun then.

This is also required for emscripten wasm support. At first I tried to register a custom BundleLoader, but bundle loaders are registered by file extension. ```js bundler.addBundleLoader('emscripten',require.resolve('./EmscriptenLoader')); ``` Would it...

No, that should not be happening. Previously, it would have tried to delete `D:\test\dist\index.html.12768.5c` but after my change, that error was silence. And now it tries to use that file...