Júlia Mir Pedrol comments

Results 159 comments of


                                            Júlia Mir Pedrol

Issue in check_samplesheet.py that incorrectly merges samples in pipelines

I am closing the issue as it seems to be fixed by #1633. Feel free to reopen if needed :)

Branch tests failing when creating a PR from dev -> master

If I understood well from the Slack conversation, this was magically fixed :) Can I close the issue?

Updating the modules.json file to new format results in branch lookup error

Hi @mahesh-panchal! I fixed this questionary in #1831. In your case the module is not found because the files are different from the ones in the modules repo. The follow...

RFC: Add --version to WorkflowMain

Hi @SamStudio8, that's a good solution! Do you think it would be worth allowing the developer to skip this when creating the pipeline template? In case they want to use...

improve template customisation documentation

@nf-core-bot fix linting

improve template customisation documentation

Thanks! I will need a ✅ from @ewels for the requested changes, or dismiss the review 😬

Fix questionary when updating `modules.json` file and commit sha is not found

Fixed by [ead1a9301d038ba33602bbde8e4086ad132f9031](https://github.com/nf-core/tools/commit/ead1a9301d038ba33602bbde8e4086ad132f9031)

Adding shared code for `modules` and `subworkflows` as `components`

@nf-core-bot fix linting

Adding shared code for `modules` and `subworkflows` as `components`

@mashehu @awgymer when you have time, can you check the new `components_create.py`? Implemented in commit [2b164ed](https://github.com/nf-core/tools/pull/1916/commits/2b164ed34c3e2cdbee61f3da3aed55c70d0ff846). Is this what you had on mind with shared commands like `components_test.py`?

Adding shared code for `modules` and `subworkflows` as `components`

@nf-core-bot fix linting