tools icon indicating copy to clipboard operation
tools copied to clipboard

Fix questionary when updating `modules.json` file and commit sha is not found

Open mirpedrol opened this issue 3 years ago • 1 comments

Closes #1824

When modules.json was updated and a commit sha for the module was not found, a questionary asked if the module is installed in a different branch. According to the documentation of Choices

If this argument is None or unset, then the value of title is used.

I changed the value to False.

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

mirpedrol avatar Sep 20 '22 10:09 mirpedrol

Codecov Report

Merging #1831 (cac8d90) into dev (0db6ecf) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #1831   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          59       59           
  Lines        7148     7148           
=======================================
  Hits         4950     4950           
  Misses       2198     2198           
Impacted Files Coverage Δ
nf_core/modules/modules_json.py 74.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 20 '22 10:09 codecov[bot]