Mircea Nistor

Results 92 comments of Mircea Nistor

> @mirceanis > > Just FYI we are still discussing right now if this repository shouldn't export hashing functions for each of the signed methods. Like `hashSetAttributeSigned` as this is...

> This is more of a code style and accessibility question than anything else to be honest. Our reasoning was that code which uses this dependency will then have to...

> I've just added changes implementing the things we discussed about. For each meta transaction method we now have a correlating `createHash` function which generates the correct hash with the...

Very true. This is related to #170 in the sense that if this library were more modular you would be able to load custom verifiers too. Otherwise the solution is...

The steps that you outlined are exactly what should happen for dereferencing a DID URL. As for the concerns, in my experience DID documents are relatively small so optimizing all...

Modularising this repo sounds like a good idea. I'm not yet sure about the actual module layout. I think the goals should be to reduce lib size (and transitive dependencies)...

The way I see it, the goals of this would be to: * allow folks to use a subset of features (if they want) to reduce their bundle sizes *...

Thank you for reporting. It is a known issue and we're working on it. The fix in the mobile app is rolling out as I write this, please update when...

It looks like there need to be changes here too, not only in the mobile app: https://github.com/uport-project/uport-connect/blob/6f0185d5788047b2ba9a2d98c2a8a2433d4e29d8/src/Connect.js#L215 `verifyJWT` will expect a `Resolver`

@simonas-notcat Right! Thanks for coming up with this. It is usable as a temporary workaround. However, this works for the wrong reasons, and will break under some situations. It overrides...