did-jwt icon indicating copy to clipboard operation
did-jwt copied to clipboard

Rename to "did-jose"

Open oed opened this issue 4 years ago • 10 comments

This package now contains many things related to the JOSE spec. We should modularize it to a few different (to be determined) packages.

Suggestion:

  • @did-jose/jws
  • @did-jose/jwe
  • @did-jose/jwt
  • @did-jose/jwt-vc
  • @did-jose/signing-*
  • @did-jose/encryption-*

oed avatar May 18 '21 13:05 oed

Hey, since this is a work item of the I&D WG, if you rename it then maybe you could also update the entry in the list of Work Items, and while doing that also check the work item leads that are listed there?

Perhaps we will also ask you at some point to give a general update on the work item progress during one of the weekly I&D WG calls.

peacekeeper avatar May 18 '21 14:05 peacekeeper

I am unclear where this label is applied. Jose has a header. Some of what is proposed is already in that header. Perhaps all of it should be in the Jose header. Otherwise difference levels of the code would be involved. That seems wrong.

TomCJones avatar May 18 '21 15:05 TomCJones

@TomCJones Are you replying to the wrong issue? :)

oed avatar May 19 '21 06:05 oed

I agree that renaming/repackaging makes sense but I don't have a strong stance here.

awoie avatar May 19 '21 06:05 awoie

@mirceanis Would love to hear your thoughts here!

oed avatar Jul 15 '21 08:07 oed

Modularising this repo sounds like a good idea. I'm not yet sure about the actual module layout. I think the goals should be to reduce lib size (and transitive dependencies) for users that only use a subset of modules, and to allow extension of the supported algorithms using user-provided modules.

mirceanis avatar Jul 17 '21 04:07 mirceanis

I think the goals should be to reduce lib size (and transitive dependencies) for users that only use a subset of modules, and to allow extension of the supported algorithms using user-provided modules.

Yep agreed! That was what I was aiming for above, e.g. with @did-jose/signing-* representing a specific alg.

oed avatar Jul 17 '21 08:07 oed

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 25 '21 09:09 stale[bot]

This is not stale.

oed avatar Sep 25 '21 10:09 oed

The way I see it, the goals of this would be to:

  • allow folks to use a subset of features (if they want) to reduce their bundle sizes
  • allow alternative implementations of algorithms (stablelib vs noble vs elliptic vs etc..)
  • allow extension with other algorithms that are not covered here yet
  • [optional] move the did-jwt-vc library here as one of the packages

Perhaps we can start with the alternative/extension use-cases, where the [currently hardcoded] mapping of algorithms to verifiers is made configurable (see #234 as well).

There is also another mapping of algorithms to signers which probably doesn't make much sense anymore, since the signer is expected to be provided externally anyway.

I haven't yet gone through the JWE code to see how we can start to slice it into modules

mirceanis avatar Jul 05 '22 11:07 mirceanis