Minseok Ryu

It seems that the new model (applying Geunyeong's input) and the original model are equivalent but using different indices. Taking the same example: The feasible region of the ORIGINAL model:...

@kibaekkim Q. What do you mean by adding a test for LBFGS?

@kibaekkim Does it just test whether the code is run or not?

Need to figure out why the pytest is not working in Github

@yim0331 Pytest works fine now. The problem was the newly introduced function "LBFGS" in the Pytest. I did not have the data downloading issue you mentioned.

@kibaekkim For testing, do I need to upload data in github?

The norm of the gradient should be clipped by "1" in this case. At this moment, I am not sure how you get the norm of model weight difference, but...

@shourya01 Have you checked the norm of gradient directly right after clipping to check if the function actually works?