David Wong
David Wong
Currently, commiting to zero polynomials will return an empty commitment: https://github.com/o1-labs/proof-systems/blob/master/poly-commitment/src/commitment.rs#L594 from @imeckler > The way to really fix it is to add the hiding generator to all the index...
Looks like [array::from_fn](https://doc.rust-lang.org/stable/std/array/fn.from_fn.html) got stabilized in the latest Rust, so we don't need array_init anymore
run: ``` $ cargo clippy -- -W clippy::pedantic ``` and fix some of the warnings
This is a large TODO (I believe @imeckler added?) so removing it from the code: https://github.com/o1-labs/proof-systems/blob/a9192195151ccfe94165ef4a0d6e70e08a3abfd8/kimchi/src/prover.rs#L206 Looking-up a tuple (f_0, f_1, ..., f_{m-1}) in a tuple of tables (T_0, ...,...
We currently use 2 zero-knowledge rows, but specify 3 in the code (under the constant `ZK_ROWS`). We use this to create enough space for three equations: * one constraint for...
In https://github.com/o1-labs/proof-systems/pull/160 I propose to use serde for serialization and deserialization. There are a few problems with that: 1. we skip some fields, because in our current logic we do...
from oamine on discord: > mistake in the mina book related to the bulletproof scheme. The challenge x sent by the verifier should only be sent after the verfier receives...
Hey @rot256, as I'm spending some time reading through your code I thought I would open this PR to more easily leave you comments :o not sure how up to...
in `absorb_evaluations` (called by both the prover and the verifier) we absorb lookup evaluations only if they are present in the proof: ```rust if let Some((l0, l1)) = zeta_evals .lookup...
work in progress - [x] rewrite the combined_inner_product in a clearer and safer way - [x] ensure that it matches the previous function behavior - [ ] replace the previous...