Mickael Maison
Mickael Maison
@FrankYang0529 Thanks for looking into this. Can you rebase on trunk? I agree with @ahuang98, a few comments could help.
Thanks for the PR, the improvement is impressive! That said the code is kind of hard to read. I wonder if we should add unit tests for the `describe()` method?
There's a spotless failure: https://github.com/apache/kafka/actions/runs/11431595728/job/31800811677?pr=17507, can you fix it?
My earlier comment `It looks like there are still a few unused methods left, for example parseEntity()` is still not addressed. You can delete `createPasswordEncoder()`, `parseEntity()`, `parseClientQuotaEntity()`, and the `Entity`...
I can't recall of any changes related to Connect classpath in 4.0. I wonder if we just notice this now as 4.0 introduced changes in `ConfigUtils`. Is Debezium shipping the...
This adds classes and methods to the public API. In order to change the public API we need to have, and approve, a KIP. See https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for the process
Absolutely not! The KIP has to be voted first. If you want to introduce an API change, it's your job convincing maintainers to vote on your KIP. Only after the...
@mumrah @cmccabe Can we merge this now? Thanks
We deleted the migration code in https://github.com/apache/kafka/pull/17293, closing.
Thanks for the report. That definitively looks like a bug. I'll take a look next week.