kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-19381: add ConfigDef.ConfigKey.Builder

Open Claudenw opened this issue 7 months ago • 7 comments

Added and extensible ConfigKey Builder class.

Claudenw avatar Jun 06 '25 11:06 Claudenw

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Jun 14 '25 03:06 github-actions[bot]

This adds classes and methods to the public API. In order to change the public API we need to have, and approve, a KIP. See https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for the process

mimaison avatar Jun 26 '25 17:06 mimaison

Kip 1198 opened:  https://cwiki.apache.org/confluence/display/KAFKA/KIP-1198%3A+implement+a+ConfigKey.Builder+class

Claudenw avatar Jul 30 '25 11:07 Claudenw

Hey @Claudenw , for the failing Java24 checks, I think you need to rebase and merge master.

sjhajharia avatar Sep 04 '25 13:09 sjhajharia

@sjhajharia or @mimaison can either of you merge this PR?

Claudenw avatar Sep 05 '25 12:09 Claudenw

Absolutely not! The KIP has to be voted first.

If you want to introduce an API change, it's your job convincing maintainers to vote on your KIP. Only after the vote has passed (see details in cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals) we'll start review the PR.

mimaison avatar Sep 05 '25 13:09 mimaison

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Dec 05 '25 03:12 github-actions[bot]