kafka KAFKA-17787: Removed --zookeeper option and logic from ConfigCommand

Removed --zookeeper option and logic from ConfigCommand

Build successful with Java 21 with cmd ./gradlew clean build -x test

Oct 15 '24 09:10 ChengyanOo

Thanks for the PR. You need to remove all the ZooKeeper logic from this file, not just the --zookeeper option. You also need to update (at least) ConfigCommandTest as your changes break this test.

Make sure to run the core tests locally (the command you mentioned skips the tests).

Gotcha, @mimaison I'll go ahead and modify the code logic, thanks for ur review!

Oct 15 '24 23:10 ChengyanOo

core tests locally (the command you mentioned skips the tests).

Hi @mimaison, it'll take too long for my computer to run the core tests so I didn't run it, is it possible for us to run it on the CI?

Oct 16 '24 09:10 ChengyanOo

There's a spotless failure: https://github.com/apache/kafka/actions/runs/11431595728/job/31800811677?pr=17507, can you fix it?

Oct 22 '24 13:10 mimaison

There's a spotless failure: https://github.com/apache/kafka/actions/runs/11431595728/job/31800811677?pr=17507, can you fix it?

Sorry I was sick for the past couple of days, I'll fix it and update the branch by today

Oct 23 '24 03:10 ChengyanOo

@ChengyanOo Could you please rebase code to run QA again?

Oct 24 '24 19:10 chia7712

My earlier comment It looks like there are still a few unused methods left, for example parseEntity() is still not addressed. You can delete createPasswordEncoder(), parseEntity(), parseClientQuotaEntity(), and the Entity and ConfigEntity classes.

Oct 24 '24 19:10 mimaison

@ChengyanOo I force-pushed a commit to your branch because it seems there were many unrelated commits in this PR.

Oct 25 '24 08:10 chia7712

@ChengyanOo I force-pushed a commit to your branch because it seems there were many unrelated commits in this PR.

Thanks for your help @chia7712

Oct 25 '24 08:10 ChengyanOo