Michael Ilyin comments

Results 101 comments of


                                            Michael Ilyin

zenoh_ext::QueryingSubscriber optimisation

Made request https://github.com/eclipse-zenoh/zenoh/pull/286 with fix for this issue

zenoh_ext::QueryingSubscriber optimisation

Made updated request https://github.com/eclipse-zenoh/zenoh/issues/287

Use unified async executor in one crate

This PR is inactive for a year. Closing it

Compile with Rust 1.47

This PR is inactive for more than a year. Closing it

add 'open' function without parameters for create session with default config

This is possible in C/C++, but for Rust the name should be different. This could be `Session::default()` for example. BTW: why it was decided to have just standalone `open` function,...

remove internal APIs from public interface

Consider using `#[doc(hidden)]` attribute for them

it's not clear what is public zenoh API just by looking at sources

The task https://github.com/eclipse-zenoh/zenoh/issues/806 is actually subtask of this

Is [no_mangle] required for plugins?

> > I had symbol clashes in the past when statically linking more plugins, to be checked if it is still the case. > > This is why the feature...

Config cannot be not be reused

So the problem is that session can't be created because of session id duplication? Then the right behaviour should for `zenoh::open` should be returning `ZResult::Err` with proper error message I...

move Publisher.write method into trait

I'd support @p-avital. I'm also kind of against to the idea of using traits as a way to separate API to "first-class" and "second-class" elements. At this moment we made...