Michael Ilyin

Results 101 comments of Michael Ilyin

All functionality which is needed by some external crates but should not be part of public API should be moved into traits available through "internal" mod. Here is an example:...

from @Mallets: - [x] `buffers` goes to internal - [x] `ZBytes` impl for `ZSlice` and `ZBuf` goes to internal - [x] `zenoh::init` goes to `internal` - [x] `plugins` goes to...

> All functionality which is needed by some external crates but should not be part of public API should be moved into traits available through "internal" mod. Here is an...

There was also a request from @kydos to provide `open` function without required `config` parameter, as usually our config is default: https://github.com/eclipse-zenoh/zenoh/issues/805, This is not decided yet and may be...

```C z_owned_config_t config; z_config_new(&config); z_owned_session_t session; z_open_options_t opts; z_open_options_default(&opts); opts.config = z_move(config); int err = z_open(&session, &opts); ``` vs ```C z_owned_config_t config; z_config_new(&config); z_owned_session_t session; z_open_options_t opts = z_open_options_default(); opts.config...

All session open parameters now comes through config, seems it's controversial idea to complexify z_open with additional parameter. If we need this in future, we can make addition open function...

accordingly to @Mallets comment in discord: same thing for `z_close`. It should accept `z_close_options_t` which is empty for now.

done in dev/1.0.0. Relaltes also to #400

Hello @cngzhnp, Would you mind to try to use rust toolchain 1.72 ?I hope with it the compilation should pass. The root cause of the issue is that that for...

@cngzhnp thank you for the solution! That's still strange for me why 0.10.1-rc fails with rust 1.72, I'll try to investigate if I find the time