Miles Johnson comments

Results 711 comments of


                                            Miles Johnson

Allow string literals for meta items of type syn::Expr

Just chiming in that it's been working great. Thanks for the quick turn around 👍

Runtime should disallow 'async public function' or typechecker should allow it

+1 Ran into this issue and it took me a while to figure it out.

Local workspaces not being symlinked to node modules (when circular deps exist)

Weird, this seems to be working again after I ran `yarn cache clean` (maybe a bad cache?). Before then, I couldn't get symlinking working at all, so I had to...

Local workspaces not being symlinked to node modules (when circular deps exist)

It still occurs for me, but very randomly. I have yet to figure out a pattern on why it happens.

Add option to change version of all workspaces together

@alexbrazier Would Lerna work here? https://github.com/lerna/lerna

feat(plugin-typescript): automatically setup project references

Not a yarn plugin, but I did something similar here: https://beemo.dev/docs/drivers/typescript#sync-project-refs Would be nice if it was supported by yarn! Here's the actual code: https://github.com/beemojs/beemo/blob/master/packages/driver-typescript/src/commands/syncProjectRefs.ts

Add a warning if default-members are configured and no package selection arguments are passed in

Maybe `--workspace` is it. This would explain the increase in bugs lately :[ I was under the assumption nextest did this automatically, but if not, giant whoops on my part!...

Add a warning if default-members are configured and no package selection arguments are passed in

Looks like `--workspace` fixed it, sorry for this dumb issue :P If possible, it may be nice to display a warning if Cargo.toml is using workspaces but `--workspaces` is not...

Add a warning if default-members are configured and no package selection arguments are passed in

Good to know. Thanks for the quick response 👍

Code coverage dropped significantly after switching to nextest

Using 1 thread seemed to bump it back up by about 9% overall, which is better than nothing. https://app.codecov.io/github/moonrepo/moon/commit/ffeaf95cd8032a1338ca6a8f5c49820cda89dd13 Thanks, I'll proceed with this for now.