hhvm Runtime should disallow 'async public function' or typechecker should allow it

Runtime should disallow 'async public function' or typechecker should allow it

Open fredemmott opened this issue 10 years ago • 4 comments

Typechecker requires 'public async function', however the runtime allows it either way.

Feb 17 '15 18:02 fredemmott

Ran into this issue and it took me a while to figure it out.

Feb 18 '15 18:02 milesj

I don't feel super strongly, but I like consistency, and forcing "async function" to always be together. So I'd say we should ban it in HHVM.

Feb 18 '15 19:02 jwatzman

Agreed. Should be a pretty simple parser change.

Feb 18 '15 19:02 paulbiss

Tracked as hhvm/hhast#548

Removed tracking, I thought it was the other way around.

Oct 04 '23 23:10 lexidor