Miles Johnson

Results 263 comments of Miles Johnson

@scotthovestadt This is usually a problem with your terminal settings. Is this an isolated Vorpal problem?

The flow types here might be useful in typing some of the TS stuff: https://github.com/dthree/vorpal/pull/272/files#diff-3a699a0719518f967e9b2df3f5549e02

Sorry, I don't have access to release.

I upgrade inquirer in the 2.0 branch, which wasn't too difficult. If someone wants to backport and submit a PR, that would be helpful. https://github.com/dthree/vorpal/commit/a3ea141233ca4cc81e8a19a061b763315663b8ed

@laurent22 The master branch is currently in development for v2, so merging this in and tagging a new release isn't possible at this time. We're also planning to remove minimist...

I moved 2.0 code to a branch and reset master. Sorry, but you'll need to rebase or start this PR again.

There's a very high level overview here: https://github.com/dthree/vorpal/issues/234 And the actual refactor PR here: https://github.com/dthree/vorpal/pull/272

Is there a reason you're trying to use both together?

@dthree Perhaps we should tag a new 1.13? A few more fixes have been merged in since.

I was away this weekend. I'll get around to reviewing this tonight.