vorpal icon indicating copy to clipboard operation
vorpal copied to clipboard

[DRAFT] TypeScript Vorpal

Open Ore4444 opened this issue 7 years ago • 15 comments

As discussed in #272:

The focus of this PR will be on re-writing Vorpal in TypeScript without adding/changing any functionality.

@milesj:

Would also make sure the deps are up to date, and probably replace minimist with yargs.

Ore4444 avatar Oct 28 '18 19:10 Ore4444

The flow types here might be useful in typing some of the TS stuff: https://github.com/dthree/vorpal/pull/272/files#diff-3a699a0719518f967e9b2df3f5549e02

milesj avatar Oct 28 '18 19:10 milesj

Any movement on this? I don't mind helping out 😄

OzairP avatar Dec 11 '18 18:12 OzairP

@OzairP i added you as a collaborator to my fork. Feel free to add commits. I might have time soon to continue developing it. Meanwhile, I will for sure be able to review your code

Ore4444 avatar Dec 12 '18 12:12 Ore4444

Do you need help getting this fork rolling? I'd be glad to hop on board with it as well. I've noticed the Vorpal Gitter is pretty active and we could probably get a few other folks from there who may be interested in a maintained version.

slinkardbrandon avatar Feb 21 '19 02:02 slinkardbrandon

@slinkardbrandon any help is welcome. I won't have time to write code soon, but I will be able to review commits and help with what I can. Added you as a collaborator

Ore4444 avatar Feb 21 '19 10:02 Ore4444

@OzairP cross posting this from https://github.com/dthree/vorpal/issues/334#issuecomment-466495091:

Quick update: there's an effort over at https://github.com/vorpaljs-reforged to reforge vorpal by first porting it to TypeScript, update dependencies and maybe fix some bugs in the process.

There's also a Slack community for further discussion about this, feel free to join!

hongaar avatar Feb 25 '19 10:02 hongaar

Yep and so anyone reading this doesn’t think we’re splitting the effort unintentionally, we’ve pulled in Ore’s work into that org for now while we work. This gives us proper git control and allows us to review all changes before merging into the fork directly.

slinkardbrandon avatar Feb 25 '19 11:02 slinkardbrandon

is anybody still interested to do this.. I mean contribute to this project?

I've made (not published yet) a complete remake of vorpal (changing also the name) made in typescript, with less code, less buggy, less and up-to-date properties and more features such as project generator (as in oclif), etc...

It has been a long work, I re-wrote the whole code few times before deciding to keep this version, so I'm also kind of jealous and protective about my work.

If anyone is interested to actively help me send a DM on twitter and I can share you permissions for accessing the code.

It's not published yet because I want to avoid the waterfall effect of potential many people switching from vorpal to this new version without being fully tested.

Edit: Btw, vorpal was a great project but it's clearly dead, also the code is a mess, that's why I didn't bother to fork and make a PR.

b4dnewz avatar Apr 05 '19 05:04 b4dnewz

Please join our Slack community https://join.slack.com/t/vorpal-workspace/shared_invite/enQtNTU3NTU3MTAzNzEyLTE4ODg2YjA1OTg0ZDMyY2I4M2Q3MGZhYjVlZDk1ZDY5NWJiZWFmYjJmYzk1ODdmYmU5ZjAzNGEzNDk5NDFhNWY

Ore4444 avatar Apr 06 '19 16:04 Ore4444

Hi! I'm a TypeScript fan and recently I'm falling in love with vorpal too.

This PR seems a good start of upgrading vorpal to be easy to maintain and use, would love to see it to be merged!

huan avatar Jul 02 '20 07:07 huan

Hi! I'm a TypeScript fan and recently I'm falling in love with vorpal too.

This PR seems a good start of upgrading vorpal to be easy to maintain and use, would love to see it to be merged!

As this repo seems to no longer be maintained some folks started work on that right here: https://github.com/vorpaljs-reforged/vorpal

sweethuman avatar Jul 02 '20 12:07 sweethuman

@sweethuman Thank you very much for telling me that our community has a TypeScript-ed version of the Vorpal, it looks great!

However, I can not find the NPM module for the vorpaljs-reforged, so how can I install that module, do we need to install it from the GitHub?

Do we have any plan to publish it as a fork version on NPM or our plan is to merge it back to the official vorpal in the future?

huan avatar Jul 04 '20 12:07 huan

It will be published in npm at one point, just use it from github

sweethuman avatar Jul 04 '20 13:07 sweethuman

@huan I'm one of the contributors to the vorpaljs-reforged project, but unfortunately, work on it has slowed down quite a bit in the last 6 months. The vorpal source code is also a bit hard to work with, which is the main reason I decided to create a new project using a similar API to vorpal, maybe you find it useful: https://github.com/hongaar/bandersnatch. Would love to hear what you think!

hongaar avatar Jul 07 '20 14:07 hongaar

@hongaar Your project looks great, a very nice typing system with a clearer code base!

huan avatar Jul 07 '20 14:07 huan