Michael Esteban

Results 12 comments of Michael Esteban

Thanks @brianfeister . I haven't had a chance to check out the Stripe Products API - it sounds interesting. Nice work!

Thanks for the PR. Please have a look at the linting errors: https://github.com/nodejs/nodejs.dev/runs/5109592874?check_suite_focus=true . This may also help the failing build

Nice work on this one! A couple of small comments/suggestions (by no means blockers): 1. When I opened the dropdown I initially didn't realise there were more than 4 locale...

Changing the locale and then navigating to a new page also does not persist the selection in the url, which is something else we will need to figure out

> Regarding the scroll, still investigating this issue, but it is a cosmetic problem which I don't think really blocks this PR. Agreed! Appreciate the changes you did make. LGTM...

I could be misunderstanding https://github.com/nodejs/nodejs.dev/issues/2149 but I think the suggestion there was to show how to install & type built-in node modules (e.g. https/stream) rather than a third party package...

I'm not sure it is mandatory? Small example here: https://stackblitz.com/edit/node-rvjjyr?file=index.js

> I've since tried removing this package both on a system that I broke last week when I did a full upgrade, and on a fresh image of the latest...

Hi @rt1301 . Carolyn has made some progress on this: https://github.com/graphql/graphql.github.io/pull/957 . There still might be an opportunity to look at implementing a burger menu though!

Before you start working on it, I believe it has been fixed in this open PR: https://github.com/graphql/graphql.github.io/pull/1019#issuecomment-799722063