Mike Suggitt

Results 14 comments of Mike Suggitt

FWIW I've come across this same issue for our builds. I've managed to create a workaround for the time being using a conditional `package.artifact` value. As above, imagine a serverless.yml...

> This is a bit tricky with current design. > > Problem is that variables by design can be used anywhere and can refer to anything, e.g. imagine following in...

Is there any updates on this at all? I'm using the plugin and when i include api keys i get an invalid cloudformation template. I'm happy to help but would...

+1 Same for me. Values seem to be ignored and limits remain untouched on API gateway. If I set all the throttle values to 1 and then deploy using 75...

You can't rely on onload alone to trigger as it never fires for cached images. see something like this -> http://mikefowler.me/2014/04/22/cached-images-load-event/

@brianfeister fair enough but probably best not to change a global method. If the cause of the problem is the image rotation work then maybe pick that out? I currently...

sorry @brianfeister I wasn't clear. I simply didn't include the commit related to image rotation in my code base. You should be able to pick out the code easily enough...

*Bump*ing this. Any thoughts on what might be causing this yet? It's causing issues on our build servers as we get up to 100+ running instances of chromedriver! Plus it...

FYI I've discovered another bug in this branch when using aspect ratio. As it's driven by the user resizing X then programmatically adjusting Y accordingly, if the user drags Y...

@levydev i'm a bit confused, why do you need to turn off cropping? surely there are a number of ways of "faking" the no crop option? Such as placing the...