serverless-aws-alias icon indicating copy to clipboard operation
serverless-aws-alias copied to clipboard

aliasStage (throttlingRateLimit, throttlingBurstLimit) setting has no effect

Open AliasIO opened this issue 4 years ago • 1 comments

I'm trying to configure throttlingRateLimit and throttlingBurstLimit for the API stage using the aliasStage setting but deploying just sets these values to the defaults (10,000 and 5,000).

...
plugins:
  - serverless-aws-alias

provider:
  ...
  aliasStage:
    throttlingBurstLimit: 10
    throttlingRateLimit: 5

functions:
  init:
    ...
    aliasStage:
      throttlingBurstLimit: 10
      throttlingRateLimit: 5

I tried to debug the issue myself, from what I can see the generated CloudFormation template does seem to be correct:

{
  "stageResource": {
      ...
      "MethodSettings": [
        {
          "ThrottlingBurstLimit": 10,
          "ThrottlingRateLimit": 5,
          "ResourcePath": "/~1",
          "HttpMethod": "GET"
        }
      ]
    },
    ...
  }
}

To work around this I need to remember to manually change the values after each deployment. I don't think I'm doing anything wrong here, is it working for anyone else?

$ sls --version
Framework Core: 1.61.3
Plugin: 3.2.7
SDK: 2.3.0
Components Core: 1.1.2
Components CLI: 1.4.0
{
  "devDependencies": {
    "serverless-aws-alias": "^1.8.0"
  }
}

cc @HyperBrain #59

AliasIO avatar Jan 23 '20 03:01 AliasIO

+1 Same for me. Values seem to be ignored and limits remain untouched on API gateway.

If I set all the throttle values to 1 and then deploy using 75 the deploy seems to work fine without error but values remain at 1

mike-suggitt avatar Jan 24 '20 14:01 mike-suggitt