mihaisc

Results 102 comments of mihaisc

This is an example of hopefully the final version of the structure that we pass to this component https://github.com/oceanprotocol/market/blob/7336224f387ca36e3c62b83a5f82e7505691f706/src/%40types/Price.d.ts#L16 . For now it assumes all fees are in ocean.

Not that relevant now. Will open another issue in the future if needed

We know how many orders there were, but we don't know the price of that dt at that point. We have 2 options: - add in subgraph spot price at...

This can be done now using [this query](https://v4.subgraph.rinkeby.oceanprotocol.com/subgraphs/name/oceanprotocol/ocean-subgraph/graphql?query=%7B%0Aorders%7B%0AlastPriceToken%0AlastPriceValue%7D%0A%7D%0A) , we need to change `lastPriceToken` from string to Token https://github.com/oceanprotocol/ocean-subgraph/pull/462

Blocked by https://github.com/oceanprotocol/ocean-subgraph/issues/447

Create a small backend to cache this? This might be a more complex discussion related to identity in the market , couple with what we will do with the 3box...

https://github.com/oceanprotocol/provider/issues/498

Is this still relevant? I think we can close it

We never use that so it's an old version. The correct way would probably be `"serve": "next start",` .