market icon indicating copy to clipboard operation
market copied to clipboard

profile metric: sales revenue

Open kremalicious opened this issue 3 years ago • 2 comments

moved over from #864:

An interesting metric would be sale revenue, meaning the amount generated by all the sales of an account, converted to fiat which then would be nice meaningful metric to only show on account teaser, and in profile header. We should first investigate and discuss on this issue if that's even possible right now.

kremalicious avatar Sep 23 '21 12:09 kremalicious

We know how many orders there were, but we don't know the price of that dt at that point. We have 2 options:

  • add in subgraph spot price at the time of the order (not 100% sure if possible, but i'm confident)
  • calculate with the current spot price

Both cases are relevant .

mihaisc avatar Sep 23 '21 20:09 mihaisc

This can be done now using this query , we need to change lastPriceToken from string to Token

https://github.com/oceanprotocol/ocean-subgraph/pull/462

mihaisc avatar May 31 '22 08:05 mihaisc

Blocked by https://github.com/oceanprotocol/ocean-subgraph/issues/447

mihaisc avatar Oct 12 '22 15:10 mihaisc

all the sales of an account, converted to fiat

Do you mean all of the sales on the current connected network or all of the sales on all networks combined?

jamiehewitt15 avatar Nov 30 '22 15:11 jamiehewitt15

Just checking that I've understood this task correctly... There is already a sales revenue metric on the profile page, so the idea is just to fetch this figure from the subgraph rather than changing the UI?

jamiehewitt15 avatar Dec 05 '22 14:12 jamiehewitt15

Blocked for now by having the pricing information. If an asset has 100 orders, we need to fetch the pricing of ocean at each order time to better determine the sales revenue.

LoznianuAnamaria avatar Dec 06 '22 11:12 LoznianuAnamaria

So the aim of this issue is now about showing accurate sales revenue as a profile metric.

Blocked by: https://github.com/oceanprotocol/ocean-subgraph/issues/582

jamiehewitt15 avatar Dec 06 '22 12:12 jamiehewitt15

The plan is not do do this anytime soon https://github.com/oceanprotocol/market/pull/1807#issuecomment-1386863729, we can reopen if that changes.

jamiehewitt15 avatar Jan 19 '23 07:01 jamiehewitt15