market icon indicating copy to clipboard operation
market copied to clipboard

wrong ENS name if account owns multiple ENS names

Open kremalicious opened this issue 3 years ago • 1 comments

When using an account which has multiple ENS names registered under its account, we show one of them, but not the actual reverse record.

  • account 0xf50f267b5689b005fe107cfdb34619f24c014457

  • has kremalicious.eth set as reverse record Screen Shot 2022-05-05 at 12 06 19

  • some other ENS domain shows up instead, one which is owned by this account, but is not set as reverse record: Screen Shot 2022-05-05 at 12 00 01

Expectation

Only the ENS name which is set as reverse record for an address is displayed.

Possible solution

For performance reasons we query an ENS subgraph, this might only hold infos about registered domains for an account, but not for its actual reverse record. Look if this is actually possible with this implementation.

Alternatively, replace this mechanism with the commented out code which does actual blockchain query to find and verify reverse record.

kremalicious avatar May 05 '22 11:05 kremalicious

Create a small backend to cache this? This might be a more complex discussion related to identity in the market , couple with what we will do with the 3box integration

mihaisc avatar May 05 '22 11:05 mihaisc