Mihai Budiu

Results 392 comments of Mihai Budiu

Yes, I would rephrase the message "directory where output is placed".

Even on Linux I could not find out how to create a project. Maybe you can add some documentation showing how to get started?

I had installed the P4 plugin by searching from the IDEA UI, and only version 0.2 was available. With version 0.3 the project settings are visible.

@olivrlee can you please fix the style issues which prevent the CI from passing?

I don't know what "opera" and "checker" are.

The issue is about map_entries, but this PR fixes the arguments to the map constructor.

We should have a checked weight implementation at the very least.

Actually this is correct. In this case the value is "missing" or "null" and in our sorting order null is the biggest value. Probably we should replace the question mark...

If you look at the parent node of a ParserState, which is a P4Parser, you will notice that it contains an IndexedVector of states. So you have to return an...

the code you have written here inserts in the IR the original node, so the IR is really unchanged.