Mihai Budiu

Results 392 comments of Mihai Budiu

I will reopen and keep tagged as question, so other people can see it.

Can you please post a complete P4 program which we can add to the testsuite?

I thought I have fixed the `setValid` a while back. Are you using the latest version of the code? I could not reproduce the problem with setValid in an action.

I have pushed a PR that tries to fix this, but my testing is not very good. https://github.com/p4lang/p4c/pull/987 Can you see whether it works?

Indeed, this back-end is much behind the other ones. There is no support for const entries yet. But please file issues for every one of these.

If you integrate the pending PR https://github.com/p4lang/p4c/pull/987 into the ebpf back-end, the code that is generated looks reasonable (but I didn't test it); hopefully someone will review the PR so...

BTW: I filed this issue https://github.com/p4lang/p4c/issues/991 about table initializers. I have a bit of a back-log this week, but I can hopefully get to it next week.

We have merged the PR with support for up to 64-bit constants into the ebpf compiler. Can you see whether it solves this issue?

We are not generating code for the initializers for tables. That's still TBD. It should be part of the ebpf compiler, though, and reused by xdp. We should probably generate...

@williamtu : do you want to push your changes to libbpf.h as a pull request?