[CALCITE-6400] MAP_ENTRIES allows null as a map key

[caicancai]

https://issues.apache.org/jira/browse/CALCITE-6400

[caicancai]

In spark, this is an error that occurs in function execution, not in type verification, so I modified the method in sqlfunctions

[chucheng92]

looks good to me in general. just one question, does this exception have to be thrown at runtime? i noticed that the exception is thrown directly in SqlFunctions.

[caicancai]

looks good to me in general. just one question, does this exception have to be thrown at runtime? i noticed that the exception is thrown directly in SqlFunctions.

@chucheng92 Thank you for your review. I write this because spark has this mechanism, but calcite is usually checked in OperadandChecker. @mihaibudiu Which method do you think should be used?

[mihaibudiu]

I don't know what "opera" and "checker" are.

[caicancai]

I don't know what "opera" and "checker" are.

Sorry, typo, it should be OperaandChecker

[chucheng92]

@caicancai could you improve the current commit name? It is different from jira and pr names.

[mihaibudiu]

The issue is about map_entries, but this PR fixes the arguments to the map constructor.

[caicancai]

The issue is about map_entries, but this PR fixes the arguments to the map constructor.

Thanks, I will modify the jira summary, the description is being discussed in jira

[sonarqubecloud[bot]]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud