Mihai Budiu

Results 392 comments of Mihai Budiu

The PR did not pass because of a minor C++ style issue. You can test this by indeed pulling this PR and building it; you can also wait until the...

A few lines lower in the code there's a reference to u32. That is a 32-bit unsigned integer.

The C compiler can be given a -I flag to indicate a path where headers are expected to be found. So probably adding `clang -I tests ....` would work (assuming...

This package does not install anything on your system, so you will need to specify the path to the headers.

I don't know if there is much we can say about this; we do not have any control on how clang generates code.

Do you plan to contribute these changes to our code?

The work in the compiler to support XDP_REDIRECT is very simple. At the time we implemented this it wasn't supported by the kernel. Maybe this has changed. @williamtu : do...

In fact, no work in the compiler is needed. You can just add XDP_REDIRECT to the p4include/xdp_model.p4 file and it will produce the right C. I will submit a PR....

Technically I don't think any changes need to be made in the compiler; it's probably just the control-plane setup that needs to be adapted. I personally don't have a machine...

Can you contribute an example?