microwish

Looks like sometimes this assignment `env->kvs = envs;` in the body of `Environment::Init` method in env.h (https://github.com/dmlc/ps-lite/blob/db6189746c2acc5e6c3611df27f38b15029a7797/include/ps/internal/env.h#L36) is not necessary. Assume we don't expect to re-assign new environment variables once...

About the lock in ZMQVan::SendMsg

1

Might the granularity of the lock be smaller? I'm not sure. I feel that reasons why the lock guards the whole function body are: 1) protect senders_ from racing 2)...

support for string Key

1

Hi there, Do you have any plan to support "string" Key? Right now Key is uint64_t or uint32_t. Thanks.

zmq_van.h, RecvMsg function; 190 } else if (i == 1) { 191 // task 192 UnpackMeta(buf, size, &(msg->meta)); 193 zmq_msg_close(zmsg); 194 bool more = zmq_msg_more(zmsg); 195 delete zmsg; 196 if...

L127, the right-hand operand seems a slip of the pen, so I correct it.