microwish

It might be better to implement SArray::operator= in a more standard way. 1 template 2 SArray& operator=(const SArray& arr) 3 { 4 if (this == &arr) return *this; 5 size_...

src/network_utils.h: Perhaps two issues on the function GetAvailablePort. First of all, although it doesn't affect the expected behavior of the function GetAvailablePort, it might be better to return -1 instead...

include/ps/internal/van.h: 63 /** 64 * \brief get next available timestamp. thread safe 65 */ 66 int GetTimestamp() { return timestamp_++; } 126 std::atomic timestamp_{0}; The implementation of GetTimestamp and its...

include/ps/internal/utils.h: 29 template 30 inline V GetEnv(const char *key, V default_val) { 31 const char *val = Environment::Get()->find(key); 32 if (val == nullptr) { 33 return default_val; 34 } else...