Michiel de Jong
Michiel de Jong
WiP issue for https://github.com/solid/solid-ui/tree/notepad-examples.
WiP issue for https://github.com/solid/solid-ui/tree/notepad-tests. Coverage of src/pad.js is now at 7.87%, should try to increase that significantly before the end of this sprint.
Consider the following code: ```js const container = document.getElementById('div-optionsFieldDependingOn') const already = {} const subject = UI.rdf.namedNode('http://example.com/#this') const exampleOptionsField = UI.rdf.namedNode('http://example.com/#exampleOptionsField') const store = UI.rdf.namedNode('http://example.com/#store') const callbackFunction = (ok, errorMessage)...
Just came across a [reference to `dom.outlineManager`](https://github.com/solid/solid-ui/blob/master/src/widgets/forms.js#L67) in the form generator - I thought the outlineManager was the part of solid-panes, that manages which pane is shown, so it's unclear...
The [shortName function in utils](https://github.com/solid/solid-ui/blob/master/src/utils.js#L406-L446) uses `this.prefixes`, which it seems is not set. Is this function used anywhere? Does it work? From what the comments say, its functionality seems to...
In https://github.com/solid/solid-ui/blob/master/src/jss/index.ts getClasses returns a StyleSheet object. getStyleSheet returns a Jss object. Wouldn't it be better to rename getClasses to getStyleSheet, and getStyleSheet to getJssObject?
shortNameForFolder returns 'example.com' for 'https://example.com/' and '/' for 'https://'. I'm not certain this is actually by design, it might be that the intended behaviour was that the domain root would...
See https://github.com/solid/solid-ui/pull/206/files#diff-8383fa1e65f77aaabf427153e899d165R318 Looks like it's awaiting a boolean and throwing away the result; I'll dig into this.